Yes, it's better. You could do something similar with left and right keys. However, I find it weird, that you combined softdrop and harddrop in one key (tapping = softdrop 1 row, holding = harddrop).
Flawed input behaviour:
- one must release Drop key before the next piece can be moved or rotated (first input for next piece will be ignored if you keep pressing Drop key)
- if one moves and rotates simultaneously, then the movement will be ignored
If you want to seperate harddrop and softdrop, then pressing softdrop should behave roughly like this:
- after 0 ms: piece moves down a row
- after 140 ms: piece moves down another row
- after 160 ms: piece moves down another row
- after 180 ms: piece moves down another row
- after 200 ms: piece moves down another row
- ... and so on
- Only the current piece is moved down. The next piece isn't accelerated. One has to release softdrop key and press it again in order to softdrop the next piece.